plugin_admin_common(): unexpected BC break

Discussions and requests related to new CMSimple features, plugins, templates etc. and how to develop.
Please don't ask for support at this forums!
Post Reply
cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

plugin_admin_common(): unexpected BC break

Post by cmb » Mon Feb 24, 2014 1:01 pm

Hello Communit,

in CMSimple_XH 1.6 the editing of standard files has been refactored. This was done in a way to keep backward compatibility (BC) with existing extensions. However, a rarely used functionality has been overlooked: to store a plugin text file from the plugin administration (admin=plugin_main&action=plugin_text resp. plugin_textsave). This functionality required a plugin to modify the superglobal $_POST, and as such was doubtful, and I have not seen it used by any plugin, until recently, where a user reported that Comments does not fully work under XH 1.6.

I'm not sure what to do here. We may try to restore full BC regarding this issue, or simply accept the BC break.

Any opinions?

Christoph
Christoph M. Becker – Plugins for CMSimple_XH

Holger
Site Admin
Posts: 3470
Joined: Mon May 19, 2008 7:10 pm
Location: Hessen, Germany

Re: plugin_admin_common(): unexpected BC break

Post by Holger » Thu Mar 13, 2014 12:16 pm

cmb wrote:However, a rarely used functionality has been overlooked:
IMO we should not roll back. It's better to fix that in the respective plugin(s) if somehow possible.
A solution is given in the thread mentioned above.

Holger

Post Reply