remove fallbacks for ancient PHP versions

Discussions and requests related to new CMSimple features, plugins, templates etc. and how to develop.
Please don't ask for support at this forums!
Post Reply
cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

remove fallbacks for ancient PHP versions

Post by cmb » Thu May 01, 2014 5:35 pm

Hello Community,

I just noticed that function sv() still has the fallback for PHP < 4.1.0 where $_SERVER was not available:

Code: Select all

function sv($s)
{
    if (!isset($_SERVER)) {
        global $_SERVER;
        $_SERVER = $GLOBALS['HTTP_SERVER_VARS'];
    }
    ...
}
I suggest that we get rid of it for XH 1.6.3, and also do a check for other such relicts (IIRC I have commented on several in the sources).

Christoph
Christoph M. Becker – Plugins for CMSimple_XH

manu
Posts: 1090
Joined: Wed Jun 04, 2008 12:05 pm
Location: St. Gallen - Schweiz
Contact:

Re: remove fallbacks for ancient PHP versions

Post by manu » Fri May 02, 2014 6:31 am

+1

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: remove fallbacks for ancient PHP versions

Post by cmb » Wed Aug 13, 2014 6:24 pm

Done (r1343).
Christoph M. Becker – Plugins for CMSimple_XH

Post Reply