link checker faulty?

[manu]

I just notice that the linkchecker refuses the following links as faulty even they are valid:
Internal link: ?page#anchor
Internal link: ./userfiles/downloads/file.pdf?v=2014_1 (this query is useful to force file reload in browser)

Just to remember, I'm short of time to do research.

Regards
manu

[cmb]

Internal link: ?page#anchor

Hm, that should work, if there is such an anchor defined on the page (either as name or id attribute of an arbitrary element).

Internal link: ./userfiles/downloads/file.pdf?v=2014_1 (this query is useful to force file reload in browser)

Indeed, this will currently fail:

Code: Select all

        if (isset($test['path']) && !isset($test['query'])) {
            $filename = $test['path'];
            if (is_file($filename) && is_readable($filename)) {
                return '200';
            }
        } 

We may consider to remove the check, that the link doesn't contain a query string.

However, the link checker is known to be broken. I've already documented the following limitations in tests/unit/LinkCheckerTest.php:

Code: Select all

// the following are (current) limitations
array('https://bugs.php.net', 'unknown'), // no HTTPS protocol support
array('./tests/unit/data/', 'internalfail'), // fails, even there's a index.(php|html)
array('anotherxh/?Welcome', '200'), // erroneously checks the same installation
array('anotherxh/?Welcome2', 'internalfail'), // fails, even if anotherxh/ would exist
array('?Secret', '200') // does not respect unpublished pages   

[cmb]

FWIW: due to http://cmsimple.org/forum/viewtopic.php?f=8&t=474 I just noticed that there is another limitation regarding the link checker: it can't deal with IDNs. I have added a respective test case (r1371).