[solved] Little bug in page_params plugin

[Holger]

Hi,

there's a little bug in page_params plugin:
If the /templates (root-)folder contains files, like a .htaccess, this files are listed as a selectable template in the dropdownlist within the plugin-tab.

The bug is in line 113 of page_params_view.php (latest version):

Code: Select all

if($file != "." && $file != "..") { 

Maybe it's enough to add a "is_dir($file)" to that line, since only subfolders are valid entrys.


Holger

BTW: Should I report issues/bugs here at the board or should I open a ticket on SF or maybe should I do both?
What's the best way?

[johnjdoe]

there's a little bug in page_params plugin:
If the /templates (root-)folder contains files, like a .htaccess, this files are listed as a selectable template in the dropdownlist within the plugin-tab.

The bug is in line 113 of page_params_view.php (latest version):

Code: Select all

if($file != "." && $file != "..") { 

Yeap, I saw it too. Thanks for posting, Holger!

[Gert]

Maybe it's enough to add a "is_dir($file)" to that line, since only subfolders are valid entrys.

This line works (after some tests):

Code: Select all

        if($file != "." && $file != ".." && is_dir($pth['folder']['templates'].$file) == 'true') { 

is_dir() needs the path ...

[Holger]

Of course, but I think that's the right way:

Code: Select all

if(is_dir($pth['folder']['templates'].$file) && $file != "." && $file != "..") { 

Holger

[Holger]

Fixed with CMSimple_XH 1.1.1

Holger