TinyMCE and internal links issue

[Holger]

I think the way how TinyMCE creates internal links is not "optimal":

Links to internal pages should not include $sn. That makes moving the installation to another folder hard:
Example href:
"/subfolder/?page:subpage".

Better should be only "?page:subpage"

/plugins/tinymce/links.php:

Code: Select all

- $list.='["' . $spacer . ' ' . substr(str_replace('"', '"', $h[$i]), 0, 30) . '", "' . $sn . '?' . $u[$i] . '"],'; 
+ $list.='["' . $spacer . substr(str_replace('"', '"', $h[$i]), 0, 30) . '", "?' . $u[$i] . '"],'; 

KR
Holger

[cmb]

Hello Holger,

I wouldn't regard this issue as a bug, but indeed, your suggestion is very reasonable (and easy to implement ), so I'll add it to the roadmap for 1.5.2.

But one thing to consider: the URLs that are inserted by tinyMCE are adjusted by the editor anyway (relative vs. absolute). So IMO it would be nice, if the editors were able to treat all URLs as relative to the calling index.php. I've implemented this a while ago for Whizzywig, as it wasn't able to keep relative URLs at all.

Christoph

[Holger]

Hi Christoph,

I wouldn't regard this issue as a bug

That's why I addressed it at issue .

Maybe it's a good idea to remame this forum to "Bugs & Issues" ?

So IMO it would be nice, if the editors were able to treat all URLs as relative to the calling index.php.

+1

KR
Holger

[cmb]

Hi Holger,

Maybe it's a good idea to remame this forum to "Bugs & Issues" ?

I guess the admin of the forum has to decide this -- however, that's fine with me. Another possibility might be to post such things to "Open Development".

So IMO it would be nice, if the editors were able to treat all URLs as relative to the calling index.php.

AFAIK that's not possible for tinyMCE without making changes to tinyMCE's core, what might not be a good idea for update reasons.

Christoph

[Holger]

I guess the admin of the forum has to decide this

Hehe

[cmb]

Hi Holger,

I've just checked the issue. Indeed the current version inserts the links with $sn prepended to the link dialog, but tinyMCE removes the $sn part nonetheless in the generated (X)HTML.

But, however, as it's more consistent and nobody seems to have arguments against it, I've commited your proposed change to SF (rev. 165).

So IMO it would be nice, if the editors were able to treat all URLs as relative to the calling index.php.

AFAIK that's not possible for tinyMCE without making changes to tinyMCE's core, what might not be a good idea for update reasons.

It seems, I was wrong. tinyMCE inserts the links relative to the calling index.php.

Christoph