Out-Commented Code in Filebrowser

A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version
Post Reply
cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Out-Commented Code in Filebrowser

Post by cmb » Wed May 07, 2014 12:13 pm

Hello Community,

due to the issues reported in http://cmsimple.org/forum/viewtopic.php?f=8&t=402 I checked the behavior of CMSimple_XH's (1.5.10 and 1.6.1) filebrowser, and there are no problems under IIS wrt. the authorization.

However, I noticed that some out-commented code in plugins/filebrowser/tpl/editorbrowser.html triggers an error notice:
Undefined variable: tx
The respective code:

Code: Select all

            <!--   <b><?php echo $tx['filetype']['folder']; ?>:</b> <?php echo $this->currentDirectory; ?> -->
Of course, this form of commenting out PHP code doesn't work (as the forum's syntax highlighter shows), and as it is already commented out since about XH 1.5, I suggest we simply remove it.

As I consider this a bug, I will add it to the 1.6.2 roadmap--voting doesn't seem to be necessary.

Christoph
Christoph M. Becker – Plugins for CMSimple_XH

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: Out-Commented Code in Filebrowser

Post by cmb » Mon May 12, 2014 7:08 pm

Fixed (r1286).
Christoph M. Becker – Plugins for CMSimple_XH

Post Reply