Submenu's heading doesn't heed $cf[menu][levels]

[cmb]

Hello Community,

I've just noticed that the heading of the submenu is always <h4> (function submenu() in cmsimple/tplfuncs.php):

Code: Select all

            return '<h4>' . $tx['submenu']['heading'] . '</h4>'
                . li($ta, 'submenu');

IMO that is a bug, as the submenu will be marked as <h4> even if the page heading might be <h5>.

I suggest we change that to:

Code: Select all

            $ml = min($cf['menu']['levels'] + 1, 6);
            return '<h' . $ml . '>' . $tx['submenu']['heading'] . '</h' . $ml . '>'
                . li($ta, 'submenu');

As the bug is a minor one, and seems to be long standing (at least since CMSimple 2.0), IMO there is no need to hurry, and it is sufficient to fix it for XH 1.6.4.

Christoph

[cmb]

Done (r1433).