Linkchecker in 1.6.5

[cmb]

I try to better distinguish the cases wether the link target is a file or not.

A link to a directory does not necessarily need a trailing slash, e.g. http://3-magi.net/demo/presentation. What about the following:

Code: Select all

Index: LinkChecker.php
===================================================================
--- LinkChecker.php   (Revision 1464)
+++ LinkChecker.php   (Arbeitskopie)
@@ -199,10 +199,12 @@
     {
         global $c, $u, $cl, $pth, $cf;
 
-        if (isset($test['path']) && !isset($test['query'])) {
+        if (isset($test['path'])) {
             $filename = $test['path'];
             if (is_file($filename) && is_readable($filename)) {
                 return '200';
+            } elseif (!is_dir($filename)) {
+                return 'file not found';
             }
         }
         if (!isset($test['query'])) {

I haven't tested either variant, though. Especially, it's still not clear what to do with ./index.php?Some_page links; these would be detected as valid, even if Some_page doesn't exist.

[manu]

you are right. this is more accurate. Some tests behave a little bit different now..