XH 1.6: Linkchecker triggers check again when going back

A place to report and discuss bugs - please mention CMSimple-version, server, platform and browser version
Post Reply
cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

XH 1.6: Linkchecker triggers check again when going back

Post by cmb » Fri Mar 20, 2015 1:59 pm

Hi everybody!

wsim123 has reported an annoying issue with regard to the link checker. After it finished its work, it may display broken links. Following one of these links and then going back, will trigger the link check again. Of course, that is nonsense, and should be fixed. A very simple solution would be to add target="_blank" to the reported links (what seems to be good for external links, anyway), but it seems to me that is not sufficient, considering the links to the page where the erroneous link is placed. If these have target=_blank, the user will be forced to open a new tab in admin mode, what I consider somewhat dangerous. If these don't have target=_blank, going back will trigger the link check right away, so fixing multiple links will trigger the link check that often.

Hence another solution seems to be more appropriate: don't do the link check on page load, but rather offer a button to do the link check. However, that would require to store the link check results somewhere (Web storage comes to mind), to be able to inject them into the DOM again.

I'm not sure, though, if it's worth doing this more demanding solution for XH 1.6. The basic question is whether we consider other behavior as bug. What do you think?
Christoph M. Becker – Plugins for CMSimple_XH

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: XH 1.6: Linkchecker triggers check again when going back

Post by cmb » Wed May 20, 2015 12:27 am

After further consideration, it appears to me that we can mark the current behavior as a flaw rather than a bug. After all, the user can easily work around it by opening the details in a new tab, and triggering the link check again by refreshing the respective page. (Some detailed documentation seems to be appropriate.)

Therefore I suggest to stick with the current behavior, and to improve it for XH 1.7.

Anyhow, we'd have to update content.htm with regard to changed URLs: http://www.frankziesing.de/cmsimple/http://svasti.de/ and http://notepad-plus-plus.org/https://notepad-plus-plus.org/. Note that the latter won't validate, because HTTPS connections can't be checked with the current solution. Shall we open a new roadmap item for this?

Perhaps it might be a good idea to remove the Notepad++ recommendation at all. While it is a really fine editor, it runs on Windows only...
Christoph M. Becker – Plugins for CMSimple_XH

cmb
Posts: 14225
Joined: Tue Jun 21, 2011 11:04 am
Location: Bingen, RLP, DE
Contact:

Re: XH 1.6: Linkchecker triggers check again when going back

Post by cmb » Wed May 27, 2015 7:41 pm

cmb wrote:Shall we open a new roadmap item for this?
I've did so: http://cmsimpleforum.com/viewtopic.php?f=29&t=8808.
Christoph M. Becker – Plugins for CMSimple_XH

Post Reply