CMSimple_XH–Forum

Wolfgang wrote: ↑

Fri Dec 25, 2020 10:12 am

My wish would be your designed xhBoard and a menu like in FHS-Adminmenu V1.2.1.

Ah, I see.
We didn't change the admin menu at first (visually).
Firstly, there are users who do not like to change.
And second: With fhs-adminmenu you have to click a little more often to get to the appropriate menu items. Some people don't like that either.
But: There is the possibility to create your own adminmenu (adminmenu.css) and you can also build your own backend-template.

frase wrote: ↑

Fri Dec 25, 2020 10:24 am

Firstly, there are users who do not like to change.
And second: With fhs-adminmenu you have to click a little more often to get to the appropriate menu items. Some people don't like that either.

IMO the proposed solution is a rather good compromise. Well done! Thank you.

I don't want to derail this thread with implementation details, but I've noticed that some new JS uses arrow functions, which have "only" been introduced with ES 6 (what is mostly unsupported by IE 11). I'm fine with dropping IE 11 support for the back-end, but that needs to be clearly documented. And if we enforce more recent browser versions, we should use that opportunity to drop some old fallbacks (AFAIK, the current admin.js still supports IE 8, what makes no sense in 2020).

cmb wrote: ↑

Fri Dec 25, 2020 1:08 pm

IMO the proposed solution is a rather good compromise.

Yes, a compromise like life itself.
But the admin menu was actually not in the foreground of the action, but the mutual influence of user templates and core styles should be minimized.
This would only have been successful if the admin menu was on an extra page and all link targets from it were displayed in an iFrame.
This, in turn, would only work if the core was significantly rewritten.
So a compromise. In the whole backend only the styles from the admin template work - except for preview and edit.

cmb wrote: ↑

Fri Dec 25, 2020 1:08 pm

I don't want to derail this thread with implementation details, but I've noticed that some new JS uses arrow functions, which have "only" been introduced with ES 6 (what is mostly unsupported by IE 11). I'm fine with dropping IE 11 support for the back-end, but that needs to be clearly documented. And if we enforce more recent browser versions, we should use that opportunity to drop some old fallbacks (AFAIK, the current admin.js still supports IE 8, what makes no sense in 2020).

In the new admin.min.js are actually some new functions in it (=>, let, ...)
This is due to the fact that for the slide functions should not use jQuery. Stupidly, in other places then again jQuery is used. This could and should perhaps be changed for the final version.
For this, it would certainly be helpful if a specialist looks at the whole JS code again and possibly revises it.
For sure some functions can go out - e.g. the actions when focusing the textareas, but the height calculations are still needed.
If obsolete fallbacks can be removed - all the better!
If this is "through", then we can also minify the admin.min.js again

frase wrote: ↑

Fri Dec 25, 2020 10:24 am

But: There is the possibility to create your own adminmenu (adminmenu.css) and you can also build your own backend-template.

Yes that's right. It's pretty easy to customize the look of the Adminmenu with adminmenu.css. I am satisfied with this possibility.

Wolfgang wrote: ↑

Fri Dec 25, 2020 4:10 pm

Yes that's right. It's pretty easy to customize the look of the Adminmenu with adminmenu.css. I am satisfied with this possibility.

You have seen that you do not have to adjust the adminmenu.css under assets, simply store an adminmenu.css in the template?

cmb wrote: ↑

Fri Dec 25, 2020 1:08 pm

I don't want to derail this thread with implementation details, but I've noticed that some new JS uses arrow functions, which have "only" been introduced with ES 6 (what is mostly unsupported by IE 11). I'm fine with dropping IE 11 support for the back-end, but that needs to be clearly documented. And if we enforce more recent browser versions, we should use that opportunity to drop some old fallbacks (AFAIK, the current admin.js still supports IE 8, what makes no sense in 2020).

It would be nice if someone would take care of admin.min.js and classic-admin.min.js who knows JS better than we do.

olape wrote: ↑

Fri Dec 25, 2020 7:08 pm

You have seen that you do not have to adjust the adminmenu.css under assets, simply store an adminmenu.css in the template?

Yes i know, that's is my practice.

Here comes an example/demonstration of how to change the admin menu relatively easily via the page template.
In this case it is the template fhs-simple with its own admin menu vertically aligned on the left.
Of course, this really only works on the pages where the template is active. If you have activated a different template for individual pages, the standard admin menu will be visible there again.

Download

Addendum to previous post:
You can of course also just put the adminmenu.css from the example into the assets/css folder, then it will affect all templates

frase wrote: ↑

Mon Dec 28, 2020 10:44 am

If you have activated a different template for individual pages, the standard admin menu will be visible there again.

frase wrote: ↑

Mon Dec 28, 2020 12:27 pm

You can of course also just put the adminmenu.css from the example into the assets/css folder, then it will affect all templates

or copy adminmenu.css from the example into all template folders where the changed menu is desired.