learnandcode wrote:Feedback for cmb and people response for filemanager plugin:
- I've had a look at Tetris_XH. But I wonder about the non validating links (which link checker did you use? The internal one will not check links inserted by plugins). And it shouldn't be a problem, if the href is enclosed with " or ' (but I'll change that anyway).
Which problems do you have regarding the high scores? I'm not aware of any.
- I've opened a discussion in the internal developer forum about including the system check to the core. Perhaps this could wait for the next major version?
- I've opened a discussion in the internal developer forum about the grammar problems with the translation of the filebrowsers "Image Folder". That could probably be fixed rather easily.
- About the usage of core language strings from plugins: it's quite common for some of the strings. In the reported case it's probably due the use of e(). IMO this is a nice feature available for plugins. But particularly for e() the resulting output is indeed somewhat hard to translate to different languages. This could and should be solved in the core. But perhaps this has time until the next major version?
PS: I've just stumbled across http://validator.w3.org/checklink
. I wasn't aware of this
Indeed it reports http://3-magi.net/plugins/tetris/highsc ... ction=list
as forbidden. But basically this was intentional. The highscore list should be seen only by players, who have already called http://3-magi.net/?CMSimple_XH/Tetris_XH
and accepted the session through a cookie, which will usually be the case for anybody who wants to play the game. So IMO that doesn't need to be fixed. OTOH: prohibiting users to call this URL without visiting the Tetris page before, was done to avoid more sensitive query parameters to be called. So probably I should consider changing the "lock" on "action=list".
And well, there's the link to http://3-magi.net/?CMSimple_XH/Tetris_XH#TOP
reported as broken. But the link can be called from the browser, and obviously it's not the same as http://3-magi.net/?CMSimple_XH/Tetris_XH
. So IMHO the link checker is in error with this report. And BTW: this link is inserted from the template, so the TOP anchor should (and is, in this case) be defined.
PPS: I've totally forgotten to mention, that the system check was introduced by Holger, not by me!